Hi Sakari, Thank you for the patch. On Tue, Sep 08, 2020 at 11:51:19AM +0300, Sakari Ailus wrote: > The maximum is currently four (4). No short is needed. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > --- > include/media/v4l2-fwnode.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h > index c47b70636e42..81e7eb123294 100644 > --- a/include/media/v4l2-fwnode.h > +++ b/include/media/v4l2-fwnode.h > @@ -40,7 +40,7 @@ struct v4l2_fwnode_bus_mipi_csi2 { > unsigned int flags; > unsigned char data_lanes[V4L2_FWNODE_CSI2_MAX_DATA_LANES]; > unsigned char clock_lane; > - unsigned short num_data_lanes; > + unsigned char num_data_lanes; > bool lane_polarities[1 + V4L2_FWNODE_CSI2_MAX_DATA_LANES]; That's a 4 bytes gain, it's useful. Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > }; -- Regards, Laurent Pinchart