Hi Laurent,
On Fri, Sep 04, 2020 at 06:06:50PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Fri, Sep 04, 2020 at 10:05:35AM +0200, Jacopo Mondi wrote:
> > On Thu, Sep 03, 2020 at 03:10:28PM +0200, Jacopo Mondi wrote:
> > > In order to establish required properties based on the selected
> > > bus type, make the 'bus-type' property mandatory. As this change
> > > documents an endpoint property, also document the 'remote-endpoint'
> > > one now that the 'endpoint' schema has been expanded.
> > >
> > > Binary compatibility with existing DTB is kept as the driver does not
> > > enforce the property to be present, and shall fall-back to default
> > > parallel bus configuration, which was the only supported bus type, if
> > > the property is not specified.
> > >
> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > > ---
> > > .../bindings/media/i2c/ovti,ov772x.yaml | 20 +++++++++++++++++++
> > > 1 file changed, 20 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > > index e7e2d31fcc23..406e9cd463a2 100644
> > > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > > @@ -41,6 +41,25 @@ properties:
> > > description: |
> > > Video output port. See ../video-interfaces.txt.
> > >
> > > + properties:
> > > + endpoint:
> > > + type: object
> > > +
> > > + properties:
> > > + remote-endpoint:
> > > + description: See ../video-interfaces.txt
> >
> > So I guess the same as you suggested for imx214 applies here (drop
> > remote-endpoint)
>
> Correct. And you should then replace additionalProperties: false with
> unevaluatedProperties: false.
>
Ah thanks, I would have just dropped additionalProperties, I didn't
know about unevaluatedProperties.
Thanks
j
> > > +
> > > + bus-type:
> > > + enum: [5, 6]
> > > +
> > > + required:
> > > + - remote-endpoint
> > > + - bus-type
> > > +
> > > + additionalProperties: false
> > > +
> > > + additionalProperties: false
> > > +
> > > required:
> > > - compatible
> > > - reg
> > > @@ -65,6 +84,7 @@ examples:
> > >
> > > port {
> > > ov772x_0: endpoint {
> > > + bus-type = <5>;
> > > remote-endpoint = <&vcap1_in0>;
> > > };
> > > };
>
> --
> Regards,
>
> Laurent Pinchart
