Re: [PULL] ov7670 changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 Mar 2010 08:35:16 -0300
Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> wrote:

> I'm now getting some warnings while compiling it with allyesconfig:

Sigh...I don't really reserve all of my silly mistakes for you...it
just must seem that way.  Fix can be pulled from the same tree:

	git://git.lwn.net/linux-2.6.git ov7670

or can be found attached.  Sorry for the noise.

jon

---
ov7670: silence some compiler warnings

Get rid of some "unused variable" warnings.  These were the result of
sloppiness and should not have happened; I'll go stand in the corner now.

Reported-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
Signed-off-by: Jonathan Corbet <corbet@xxxxxxx>
---
 drivers/media/video/ov7670.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/media/video/ov7670.c b/drivers/media/video/ov7670.c
index a3fee6a..798b4c9 100644
--- a/drivers/media/video/ov7670.c
+++ b/drivers/media/video/ov7670.c
@@ -873,8 +873,7 @@ static int ov7670_s_parm(struct v4l2_subdev *sd, struct v4l2_streamparm *parms)
 	struct v4l2_captureparm *cp = &parms->parm.capture;
 	struct v4l2_fract *tpf = &cp->timeperframe;
 	struct ov7670_info *info = to_state(sd);
-	unsigned char clkrc;
-	int ret, div;
+	int div;
 
 	if (parms->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
 		return -EINVAL;
@@ -1280,9 +1279,9 @@ static int ov7670_g_autoexp(struct v4l2_subdev *sd, __s32 *value)
 
 	ret = ov7670_read(sd, REG_COM8, &com8);
 	if (com8 & COM8_AEC)
-		*value = V4L2_EXPOSURE_AUTO;
+		*atype = V4L2_EXPOSURE_AUTO;
 	else
-		*value = V4L2_EXPOSURE_MANUAL;
+		*atype = V4L2_EXPOSURE_MANUAL;
 	return ret;
 }
 
-- 
1.7.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux