On Friday 26 March 2010 12:24:26 Guennadi Liakhovetski wrote: > On Fri, 26 Mar 2010, Hans Verkuil wrote: > > > On Friday 26 March 2010 08:06:42 Guennadi Liakhovetski wrote: > > > V4L2_STD_PAL, V4L2_STD_SECAM, and V4L2_STD_NTSC are not the only composite > > > standards. Currently, e.g., if a driver supports all of V4L2_STD_PAL_B, > > > V4L2_STD_PAL_B1 and V4L2_STD_PAL_G, the enumeration will report > > > V4L2_STD_PAL_BG and not the single standards, which can confuse > > > applications. Fix this by only clearing simple standards from the mask. > > > This, of course, will only work, if composite standards are listed before > > > simple ones in the standards array in v4l2-ioctl.c, which is currently > > > the case. > > > > Do you have an specific example where the current implementation will do the > > wrong thing? > > Yes - sh_vou with gstreamer. gstreamer enumerates standards and gest > PAL_BG but not PAL_B or PAL_G. See my review of the ak881x tv-encoder. This ENUMSTD patch just papers over a bug in the ak881x driver. So the real fix has to be done there and not here. This patch would otherwise lead to an unmanagable mess of videostandards for the end-user. Regards, Hans > > Thanks > Guennadi > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
