Hi Mauro and others, Mauro Carvalho Chehab wrote: > Sakari Ailus wrote: >> Mauro Carvalho Chehab wrote: >>> Hi Sakari, >> >> Hi Mauro, >> >> ... >>> The idea of having a common file handle at the V4L2 core is interesting, but >>> I see some troubles on it. As you said on this changeset's comment: >>> >>> V4L/DVB: V4L: File handles >>> >>> This patch adds a list of v4l2_fh structures to every video_device. >>> It allows using file handle related information in V4L2. The event interface >>> is one example of such use. >>> >>> Video device drivers should use the v4l2_fh pointer as their >>> file->private_data. >>> >>> You're saying that the drivers should use struct v4l2_fh, but there >>> aren't any patches on your series enforcing this change. >> >> Oh, there should be an "if" there. It is described better in >> Documentation/video4linux/v4l2-framework.txt . > > Even there, it is not clear that this is an optional interface. Also, as I am > understanding, you'll likely add other things there, so the better would be > to add some notes at the header files that implement those functions, stating > when and how they should be used. Right. I'll do the changes to the documentation and add an example, too. ... > It is always a good idea to add at least one use case when a new API is > added on kernel. So, I prefer if you could send those changes together > with some use case. Hans is planning to use on ivtv (as his email on > this thread). Also Guennadi said me once, at irc, that he has also something > ready or almost ready just waiting for this merge. So, it would be really > nice if you can send either one of the implementations together with the > patch series. This helps to better understand about the usecases. I'll work with Hans and Guennadi on this. Let's see when we have a combined patchset ready. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
