Re: [PATCH] media: ti-vpe: cal: Fix compilation on 32-bit ARM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 23, 2020 at 08:02:57AM +0300, Laurent Pinchart wrote:
> When compiled on 32-bit ARM, the CAL driver fails with the FIELD_PREP()
> macro complaining that the mask is not constant. While all callers of
> the inline cal_write_field() function pass a constant mask, the mask
> parameter itself is a variable, which likely doesn't please the
> compiler.
> 
> Fix it by replacing FIELD_PREP() with a manual implementation.
> 
> Fixes: 50797fb30b95 ("media: ti-vpe: cal: Turn reg_(read|write)_field() into inline functions")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Thanks!

Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux