Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ricardo Maraschini wrote:
> --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300
> +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300
> @@ -1401,7 +1401,8 @@
>        case CX88_BOARD_SAMSUNG_SMT_7020:
>                dev->ts_gen_cntrl = 0x08;
> 
> -               struct cx88_core *core = dev->core;
> +               struct cx88_core *core;
> +               core = dev->core;
> 
>                cx_set(MO_GP0_IO, 0x0101);
> 
> 
> 
> Signed-off-by: Ricardo Maraschini <ricardo.maraschini@xxxxxxxxx>
> 
> 
> For any comments, please CC me in the message. I am waiting moderator
> approval to subscribe to this mailing list
> --

Hi,

Did you test this patch (by building this driver)?
I think not.

Also, the Signed-off-by: line should be before the patch, not after it.

~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux