Hi Jacopo, Thank you for the patch. On Tue, Aug 18, 2020 at 02:20:11PM +0200, Jacopo Mondi wrote: > In order to establish required properties based on the selected > bus type, make the 'bus-type' property mandatory. > > Binary compatibility with existing DTB is kept as the driver does not > enforce the property to be present, and shall fall-back to default > parallel bus configuration, which was the only supported bus type, if > the property is not specified. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/media/i2c/ov772x.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml > index 2b84fefeb4aa..75dad40f70cc 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov772x.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ov772x.yaml > @@ -47,9 +47,15 @@ properties: > endpoint: > type: object > properties: > + bus-type: > + enum: [5, 6] > + > remote-endpoint: > description: A phandle to the bus receiver's endpoint node. > > + required: > + - bus-type > + > additionalProperties: false > > required: > @@ -75,6 +81,7 @@ examples: > > port { > ov772x_0: endpoint { > + bus-type = <5>; > remote-endpoint = <&vcap1_in0>; > }; > }; -- Regards, Laurent Pinchart