On 14.08.2020 01:46, Sakari Ailus wrote: > Hi Eugen, > > On Fri, Jul 03, 2020 at 10:44:13AM +0300, Eugen Hristev wrote: >> Add bindings documentation for microchip CSI2 Demultiplexer controller. > > ... > >> + port@1: >> + type: object >> + description: >> + Output port node, single endpoint, describing the output pad. >> + >> + properties: >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> + reg: >> + const: 1 >> + >> + patternProperties: >> + "^endpoint@[0-9a-f]$": >> + type: object >> + >> + properties: >> + reg: >> + enum: [0, 1, 2, 3] >> + description: virtual channel for the endpoint > > Unless you need this right now I'd just hard code this to zero in the > driver. You can't have more endpoints for active devices anyway, can you? Hello Sakari, You are right, but, the virtual ID must be written in hardware registers. So I can take the virtual ID from this property. Otherwise, if I hardcode this in the driver, another virtual ID would be impossible to use without changing the driver. And if the binding is accepted without this property, it will be 'set in stone' and difficult to change afterwards. What do you think ? Eugen > > -- > Sakari Ailus >
