On Fri, Aug 14, 2020 at 11:18:36PM +0300, Sakari Ailus wrote: > On Fri, Aug 14, 2020 at 07:30:12PM +0300, Andy Shevchenko wrote: > > This constant is used in several places in the code, define it > > for better maintenance. ... > > +#define CIO2_MAX_ENTRIES (PAGE_SIZE / sizeof(u32)) > > How about calling this CIO2_ENTRIES_PER_LOP (or CIO2_LOP_ENTRIES) instead? Sure. (I like the latter). -- With Best Regards, Andy Shevchenko