Hi Andy, Thanks for the patchset. On Fri, Aug 14, 2020 at 07:30:11PM +0300, Andy Shevchenko wrote: > The code looks more nicer if we use: > while (i--) > instead: > for (i = i - 1; i >= 0; i--) > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > index 92f5eadf2c99..c7c3692a6e72 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > @@ -887,7 +887,7 @@ static int cio2_vb2_buf_init(struct vb2_buffer *vb) > b->lop[i][j] = cio2->dummy_page_bus_addr >> PAGE_SHIFT; > return 0; > fail: > - for (i--; i >= 0; i--) > + while (i--) Nice! This would also allow making i unsigned again. > dma_free_coherent(dev, CIO2_PAGE_SIZE, > b->lop[i], b->lop_bus_addr[i]); > return -ENOMEM; -- Sakari Ailus
