Hi,
Am Samstag, den 20.03.2010, 16:08 +0200 schrieb Евгений Бацман:
> 2010/3/20 hermann pitton <hermann-pitton@xxxxxxxx>:
> > Hi, Евгений,
> >
> > is there any reason, why you set the charge pump bit to low and slow
> > tuning on a non FM tuner?
> >
> > Cheers,
> > Hermann
> >
> >
> > Am Freitag, den 19.03.2010, 20:32 +0200 schrieb Евгений Бацман:
> >> A add tv tuner AverTV Studio 509UA but radio now not
> >> work(tuner_tea5764hn not in kernel)
> >>
> >>
> >>
> >> diff -r a/linux/drivers/media/common/tuners/tuner-types.c
> >> --- a/linux/drivers/media/common/tuners/tuner-types.c 2010-03-17
> >> 20:38:10.000000000 +0200
> >> +++ b/linux/drivers/media/common/tuners/tuner-types.c 2010-03-19
> >> 14:25:24.000000000 +0200
> >> @@ -1353,6 +1353,30 @@
> >> .count = ARRAY_SIZE(tuner_sony_btf_pxn01z_ranges),
> >> },
> >> };
> >> +/* ------------ TUNER_PHILIPS_FQ1216ME_MK5 - Philips PAL ------------ */
> >> +
> >> +static struct tuner_range tuner_fq1216me_mk5_pal_ranges[] = {
> >> + { 16 * 158.00 /*MHz*/, 0x8e, 0x01, },
> >> + { 16 * 442.00 /*MHz*/, 0x8e, 0x02, },
> >> + { 16 * 999.99 , 0x8e, 0x04, },
> >> +};
> >> +
> >> +static struct tuner_params tuner_fq1216me_mk5_params[] = {
> >> + {
> >> + .type = TUNER_PARAM_TYPE_PAL,
> >> + .ranges = tuner_fq1216me_mk5_pal_ranges,
> >> + .count = ARRAY_SIZE(tuner_fq1216me_mk5_pal_ranges),
> >> + .cb_first_if_lower_freq = 1,
> >> + .has_tda9887 = 1,
> >> + .port1_active = 1,
> >> + .port2_active = 1,
> >> + .port2_invert_for_secam_lc = 1,
> >> + .default_top_mid = -2,
> >> + .default_top_secam_low = -2,
> >> + .default_top_secam_mid = -2,
> >> + .default_top_secam_high = -2,
> >> + },
> >> +};
> >>
> >> /* --------------------------------------------------------------------- */
> >>
> >> @@ -1827,6 +1851,11 @@
> >> .params = tuner_sony_btf_pxn01z_params,
> >> .count = ARRAY_SIZE(tuner_sony_btf_pxn01z_params),
> >> },
> >> + [TUNER_PHILIPS_FQ1216ME_MK5] = { /* Philips PAL */
> >> + .name = "Philips PAL/SECAM multi (FQ1216ME MK5)",
> >> + .params = tuner_fq1216me_mk5_params,
> >> + .count = ARRAY_SIZE(tuner_fq1216me_mk5_params),
> >> + },
> >> };
> >> EXPORT_SYMBOL(tuners);
> >>
> >> diff -r a/linux/drivers/media/video/saa7134/saa7134-cards.c
> >> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c 2010-03-17
> >> 20:38:10.000000000 +0200
> >> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c 2010-03-19
> >> 16:34:17.000000000 +0200
> >> @@ -5411,7 +5411,44 @@
> >> .gpio = 0x389c00,
> >> } },
> >> },
> >> -
> >> + [SAA7134_BOARD_AVERMEDIA_STUDIO_509UA] = {
> >> + /* Evgen Batsman <evgenbatsman@xxxxxxxxx> */
> >> + .name = "Avermedia AVerTV Studio 509UA",
> >> + .audio_clock = 0x00187de7,
> >> + .tuner_type = TUNER_PHILIPS_FQ1216ME_MK5,
> >> + .radio_type = UNSET,
> >> + .tuner_addr = ADDR_UNSET,
> >> + .radio_addr = ADDR_UNSET,
> >> + .tda9887_conf = TDA9887_PRESENT,
> >> + .gpiomask = 0x03,
> >> + .inputs = { {
> >> + .name = name_tv,
> >> + .vmux = 1,
> >> + .amux = TV,
> >> + .tv = 1,
> >> + .gpio = 0x00,
> >> + }, {
> >> + .name = name_comp1,
> >> + .vmux = 3,
> >> + .amux = LINE1,
> >> + .gpio = 0x00,
> >> + }, {
> >> + .name = name_svideo,
> >> + .vmux = 8,
> >> + .amux = LINE1,
> >> + .gpio = 0x00,
> >> + } },
> >> + .radio = {
> >> + .name = name_radio,
> >> + .amux = LINE2,
> >> + .gpio = 0x01,
> >> + },
> >> + .mute = {
> >> + .name = name_mute,
> >> + .amux = LINE1,
> >> + .gpio = 0x00,
> >> + },
> >> + },
> >> };
> >>
> >> const unsigned int saa7134_bcount = ARRAY_SIZE(saa7134_boards);
> >> @@ -6567,6 +6604,12 @@
> >> .subvendor = 0x107d,
> >> .subdevice = 0x6655,
> >> .driver_data = SAA7134_BOARD_LEADTEK_WINFAST_DTV1000S,
> >> + },{
> >> + .vendor = PCI_VENDOR_ID_PHILIPS,
> >> + .device = PCI_DEVICE_ID_PHILIPS_SAA7133,
> >> + .subvendor = 0x1461, /* Avermedia Technologies Inc */
> >> + .subdevice = 0xa14b,
> >> + .driver_data = SAA7134_BOARD_AVERMEDIA_STUDIO_509UA,
> >> }, {
> >> /* --- boards without eeprom + subsystem ID --- */
> >> .vendor = PCI_VENDOR_ID_PHILIPS,
> >> diff -r a/linux/drivers/media/video/saa7134/saa7134.h
> >> --- a/linux/drivers/media/video/saa7134/saa7134.h 2010-03-17
> >> 20:38:10.000000000 +0200
> >> +++ b/linux/drivers/media/video/saa7134/saa7134.h 2010-03-19
> >> 13:13:00.000000000 +0200
> >> @@ -302,6 +302,7 @@
> >> #define SAA7134_BOARD_LEADTEK_WINFAST_DTV1000S 175
> >> #define SAA7134_BOARD_BEHOLD_505RDS_MK3 176
> >> #define SAA7134_BOARD_HAWELL_HW_404M7 177
> >> +#define SAA7134_BOARD_AVERMEDIA_STUDIO_509UA 178
> >>
> >> #define SAA7134_MAXBOARDS 32
> >> #define SAA7134_INPUT_MAX 8
> >> diff -r a/linux/drivers/media/video/saa7134/saa7134-input.c
> >> --- a/linux/drivers/media/video/saa7134/saa7134-input.c 2010-03-17
> >> 20:38:10.000000000 +0200
> >> +++ b/linux/drivers/media/video/saa7134/saa7134-input.c 2010-03-19
> >> 13:09:44.000000000 +0200
> >> @@ -569,6 +569,7 @@
> >> case SAA7134_BOARD_AVERMEDIA_STUDIO_307:
> >> case SAA7134_BOARD_AVERMEDIA_STUDIO_507:
> >> case SAA7134_BOARD_AVERMEDIA_STUDIO_507UA:
> >> + case SAA7134_BOARD_AVERMEDIA_STUDIO_509UA:
> >> case SAA7134_BOARD_AVERMEDIA_GO_007_FM:
> >> case SAA7134_BOARD_AVERMEDIA_M102:
> >> case SAA7134_BOARD_AVERMEDIA_GO_007_FM_PLUS:
> >> diff -r a/linux/include/media/tuner.h b/linux/include/media/tuner.h
> >> --- a/linux/include/media/tuner.h 2010-03-17 20:38:10.000000000 +0200
> >> +++ b/linux/include/media/tuner.h 2010-03-19 14:31:02.000000000 +0200
> >> @@ -130,6 +130,7 @@
> >> #define TUNER_PHILIPS_CU1216L 82
> >> #define TUNER_NXP_TDA18271 83
> >> #define TUNER_SONY_BTF_PXN01Z 84
> >> +#define TUNER_PHILIPS_FQ1216ME_MK5 85
> >>
> >> /* tv card specific */
> >> #define TDA9887_PRESENT (1<<0)
> Hi Hermann ,
> yes indeed this tuner does not need this option.
If I get you right, fast tuning is not the default on this one?
It doesn't matter much anyway on non FM tuners and even on the
FM1216ME/I MK5 low charge pump is not explicitly recommended anymore,
like it was on previous FM MK3 tuners. Just did wonder why you set it
now on this one.
Please reuse then tuner_fm1216me_mk3_pal_ranges instead to duplicate
them.
You also should add the tuner in tveeprom.c, since many drivers use it
for auto detection.
If you have a gpio remote, you must add the card to the gpio remotes in
saa7134-cards.c too or remove it from saa7134-input.c.
Patches on the list are picked up by "patchwork".
Yours is in a bad shape, because of broken lines caused by your mailer.
https://patchwork.kernel.org/patch/86993
Consider to send it also as attachment and track it at patchwork.
Please run "make checkpatch" once. Guess only one warning for a missing
space after comma.
Please try README.patches. All patches must have a Signed-of-by line
with name and e-mail address and should start with [PATCH] in the
subject.
I think best would be to create two patches.
1/2 adds the new tuner. (tuner-types.c/tuner.h/tveeprom.c)
2/2 adds the new Avermedia card.
Else it looks fine.
Cheers,
Hermann
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
