Hi Sakari, Thank you for the review. On Fri, Jul 31, 2020 at 4:23 PM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Fri, Jul 31, 2020 at 10:24:47AM +0100, Lad Prabhakar wrote: > > @@ -2875,8 +2891,10 @@ static int ov5640_s_stream(struct v4l2_subdev *sd, int enable) > > > > if (sensor->ep.bus_type == V4L2_MBUS_CSI2_DPHY) > > ret = ov5640_set_stream_mipi(sensor, enable); > > - else > > + else if (sensor->ep.bus_type == V4L2_MBUS_PARALLEL) > > ret = ov5640_set_stream_dvp(sensor, enable); > > + else > > + ret = ov5640_set_stream_bt656(sensor, enable); > > I'd also check for the Bt.656 mode here, rather than assuming it. > Sure will do. > Could you also update the DT bindings, given that the sensor appears to > support Bt.656 as well? I believe this requires the bus-type property, too. > Aha I ignored because this wasnt updated when DVP support was added to the driver, but will do now. Cheers, Prabhakar > > > > if (!ret) > > sensor->streaming = enable; > > -- > Kind regards, > > Sakari Ailus
