On Mon, Jul 27, 2020 at 04:20:39AM +0000, Qiu, Tian Shu wrote: > Reviewed-by: Tianshu Qiu <tian.shu.qiu@xxxxxxxxx> This doesn't really make sense. The patch already contains your Signed-off-by, which means you participated in its development (see Documentation/process/submitting-patches.rst), and I don't think it makes sense to review your own patch. > > -----Original Message----- > > From: Cao, Bingbu <bingbu.cao@xxxxxxxxx> > > Sent: Monday, July 27, 2020 12:12 PM > > To: linux-media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; helgaas@xxxxxxxxxx > > Cc: sakari.ailus@xxxxxxxxxxxxxxx; Qiu, Tian Shu <tian.shu.qiu@xxxxxxxxx>; Cao, Bingbu <bingbu.cao@xxxxxxxxx>; > > bingbu.cao@xxxxxxxxxxxxxxx > > Subject: [PATCH] MAINTAINERS: Fix email typo and correct name of Tianshu > > > > Fix the typo in email address of Tianshu Qiu and correct the name. > > > > Signed-off-by: Bingbu Cao <bingbu.cao@xxxxxxxxx> > > Signed-off-by: Tianshu Qiu <tian.shu.qiu@xxxxxxxxx> Also, Documentation/process/submitting-patches.rst says "the last Signed-off-by: must always be that of the developer submitting the patch," which means these should be reversed, since Bingbu submitted the patch. > > Reported-by: Bjorn Helgaas <helgaas@xxxxxxxxxx> I don't care whether you include this or not, but if you do, it would typically go first, since the report comes before the writing of the patch. > > --- > > MAINTAINERS | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5392f00cec46..638dfa99751b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -8765,7 +8765,7 @@ INTEL IPU3 CSI-2 CIO2 DRIVER > > M: Yong Zhi <yong.zhi@xxxxxxxxx> > > M: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > M: Bingbu Cao <bingbu.cao@xxxxxxxxx> > > -R: Tian Shu Qiu <tian.shu.qiu@xxxxxxxxx> > > +R: Tianshu Qiu <tian.shu.qiu@xxxxxxxxx> > > L: linux-media@xxxxxxxxxxxxxxx > > S: Maintained > > F: Documentation/userspace-api/media/v4l/pixfmt-srggb10-ipu3.rst > > @@ -8774,7 +8774,7 @@ F: drivers/media/pci/intel/ipu3/ > > INTEL IPU3 CSI-2 IMGU DRIVER > > M: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > R: Bingbu Cao <bingbu.cao@xxxxxxxxx> > > -R: Tian Shu Qiu <tian.shu.qiu@xxxxxxxxx> > > +R: Tianshu Qiu <tian.shu.qiu@xxxxxxxxx> > > L: linux-media@xxxxxxxxxxxxxxx > > S: Maintained > > F: Documentation/admin-guide/media/ipu3.rst > > @@ -12609,7 +12609,7 @@ T: git git://linuxtv.org/media_tree.git > > F: drivers/media/i2c/ov2685.c > > > > OMNIVISION OV2740 SENSOR DRIVER > > -M: Tianshu Qiu <tian.shu.qiua@xxxxxxxxx> > > +M: Tianshu Qiu <tian.shu.qiu@xxxxxxxxx> > > R: Shawn Tu <shawnx.tu@xxxxxxxxx> > > R: Bingbu Cao <bingbu.cao@xxxxxxxxx> > > L: linux-media@xxxxxxxxxxxxxxx > > -- > > 2.7.4 >
