On Mon, Jul 27, 2020 at 01:10:56AM +0300, Laurent Pinchart wrote: > Hi Peilin, > > Thank you for the patch. > > On Sun, Jul 26, 2020 at 06:05:57PM -0400, Peilin Ye wrote: > > video_put_user() is copying uninitialized stack memory to userspace. Fix > > it by initializing `ev32` and `vb32` using memset(). > > How about mentioning that this is caused by the compiler not > initializing the holes ? Maybe something along the lines of > > video_put_user() is copying uninitialized stack memory to userspace due > to the compiler not initializing holes in the structures declared on the > stack. Fix it by initializing the structures using memset(). > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> I see, that makes sense. I will send a v3. Thank you, Peilin Ye
