Hi Markus, It seems that Lad Prabhakar detected a critical issue introduced by the patch instead of a minor bug fixed by it. So, we should take care of this first, but I will address your notes as well. -- Evgeny Novikov Linux Verification Center, ISP RAS http://linuxtesting.org 23.07.2020, 23:15, "Markus Elfring" <markus.elfring@xxxxxx>: >> In case of errors vpif_probe_complete() releases memory for vpif_obj.sd >> and unregisters the V4L2 device. But then this is done again by >> vpif_probe() itself. The patch removes the cleaning from >> vpif_probe_complete(). > > * An imperative wording can be preferred for the change description, > can't it? > > * Would you like to add the tag “Fixes” to the commit message? > > Regards, > Markus
