Hi Gregor, On 7/22/20 6:32 AM, Gregor Jasny wrote: > Hello, > > On 7/21/20 5:14 PM, Ariel D'Alessandro wrote: >> Hello there, >> >> Here's another step on porting v4l-utils to meson build system. >> Following the discussion thread for v1, several changes were added (see >> Changelog below). >> >> Further testing, deeper reviews, more comments, are all welcome :-) > > Thanks you for polishing the patch. It looks good and the Debian package > properly builds. > > Before merging to master the build system needs to catch-up with the master > branch. For example the following got added to configure.ac: Right. I'll do that quickly. > >> +# Obtain git SHA of HEAD >> +AC_SUBST(GIT_SHA, ["-DGIT_SHA=\$(shell if test -d \$(top_srcdir)/.git ; then >> git -C \$(top_srcdir) rev-parse HEAD ; else printf '\"not available\"'; fi)"]) >> + >> +# Obtain git commit count of HEAD >> +AC_SUBST(GIT_COMMIT_CNT, ["-DGIT_COMMIT_CNT=\$(shell if test -d >> \$(top_srcdir)/.git ; then printf '-'; git -C \$(top_srcdir) rev-list --count >> HEAD ; fi)"]) > > I'm wondering if we should drop autotools shortly after the meson patch was > merged to prevent further drift. +1 That'd be a good way to go. Thanks, Ariel
