Em Wed, 22 Jul 2020 16:58:31 +0530
Rahul Gottipati <rahul.blr97@xxxxxxxxx> escreveu:
> This removes whitespaces at the beginning of a few lines to fix
> some checkpatch.pl warnings.
>
> Signed-off-by: Rahul Gottipati <rahul.blr97@xxxxxxxxx>
> ---
> Changes in v2:
> Distributed changes across 2 patches instead of the previous 1
>
> drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
> index 9404a678fa6f..9cdcbe774229 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
> @@ -512,7 +512,7 @@ const struct atomisp_format_bridge atomisp_output_fmts[] = {
> };
>
> const struct atomisp_format_bridge *atomisp_get_format_bridge(
> - unsigned int pixelformat)
> + unsigned int pixelformat)
This is still a coding style violation, as:
1) the continuation line won't be aligned after the open parenthesis;
2) the line will end with an open parenthesis.
A fix would be:
const struct atomisp_format_bridge *
atomisp_get_format_bridge(unsigned int pixelformat)
The same applies to similar patterns.
Yet, patches to atomisp have a high chance of having conflicts,
and being rejected, as we're doing lots of non-aesthetic changes
on this driver.
> {
> unsigned int i;
>
> @@ -525,7 +525,7 @@ const struct atomisp_format_bridge *atomisp_get_format_bridge(
> }
>
> const struct atomisp_format_bridge *atomisp_get_format_bridge_from_mbus(
> - u32 mbus_code)
> + u32 mbus_code)
> {
> unsigned int i;
>
> @@ -607,7 +607,7 @@ static int atomisp_enum_input(struct file *file, void *fh,
> }
>
> static unsigned int atomisp_subdev_streaming_count(
> - struct atomisp_sub_device *asd)
> + struct atomisp_sub_device *asd)
> {
> return asd->video_out_preview.capq.streaming
> + asd->video_out_capture.capq.streaming
Thanks,
Mauro
