On Tue, Jul 21, 2020 at 2:26 PM Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> wrote: > > Hi, > > On 20.07.20 21:25, Helen Koike wrote: > > > > > > On 7/18/20 11:59 AM, Dafna Hirschfeld wrote: > >> The code in rkisp1-isp.c requires access to struct 'rkisp1_device' > >> in several places. It access it using the 'container_of' macro. > >> This patch adds a pointer to 'rkisp1_device' in struct 'rkisp1_isp' > >> to simplify the access. > > > > What is wrong with container_of? > > I remember Laurent suggested it a while ago. > I also feel container_of is a bit cumbersome and other entities already have a pointer to rkisp1_device. > Do we even need the rkisp1_isp struct? Could we just pass rkisp1_device instead? Best regards, Tomasz
