Laurent Pinchart wrote: > Hi Mauro, > > On Thursday 18 March 2010 13:50:50 Laurent Pinchart wrote: >> On Thursday 18 March 2010 13:41:36 Mauro Carvalho Chehab wrote: >>> Laurent Pinchart wrote: >>>> On Thursday 18 March 2010 13:19:57 Mauro Carvalho Chehab wrote: >>>>> Laurent Pinchart wrote: >>>>>> Those control, as their names imply, control the camera aperture >>>>>> settings. >>>>>> >>>>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >>>>>> --- >>>>>> >>>>>> Documentation/DocBook/v4l/compat.xml | 11 +++++++++++ >>>>>> Documentation/DocBook/v4l/controls.xml | 19 +++++++++++++++++++ >>>>>> Documentation/DocBook/v4l/videodev2.h.xml | 3 +++ >>>>>> include/linux/videodev2.h | 3 +++ >>>>>> 4 files changed, 36 insertions(+), 0 deletions(-) >>>>>> >>>>>> diff --git a/Documentation/DocBook/v4l/compat.xml >>>>>> b/Documentation/DocBook/v4l/compat.xml index b9dbdf9..854235b 100644 >>>>>> --- a/Documentation/DocBook/v4l/compat.xml >>>>>> +++ b/Documentation/DocBook/v4l/compat.xml >>>>>> @@ -2332,6 +2332,17 @@ more information.</para> >>>>>> >>>>>> </listitem> >>>>>> >>>>>> </orderedlist> >>>>>> >>>>>> </section> >>>>>> >>>>>> + <section> >>>>>> + <title>V4L2 in Linux 2.6.34</title> >>>>>> + <orderedlist> >>>>>> + <listitem> >>>>>> + <para>Added >>>>>> +<constant>V4L2_CID_IRIS_ABSOLUTE</constant> and >>>>>> +<constant>V4L2_CID_IRIS_RELATIVE</constant> controls to the >>>>>> + <link linkend="camera-controls">Camera controls class</link>. >>>>>> + </para> >>>>>> + </listitem> >>>>>> + </orderedlist> >>>>>> >>>>>> </section> >>>>>> >>>>>> <section id="other"> >>>>>> >>>>>> diff --git a/Documentation/DocBook/v4l/controls.xml >>>>>> b/Documentation/DocBook/v4l/controls.xml index f464506..c412e89 >>>>>> 100644 --- a/Documentation/DocBook/v4l/controls.xml >>>>>> +++ b/Documentation/DocBook/v4l/controls.xml >>>>>> @@ -1825,6 +1825,25 @@ wide-angle direction. The zoom speed unit is >>>>>> driver-specific.</entry> >>>>>> >>>>>> <row><entry></entry></row> >>>>>> >>>>>> <row> >>>>>> >>>>>> + <entry >>>>>> spanname="id"><constant>V4L2_CID_IRIS_ABSOLUTE</constant> </entr >>>>>> y> + <entry>integer</entry> >>>>>> + </row><row><entry spanname="descr">This control sets the >>>>>> +camera aperture's to the specified value. The unit is undefined. >>>>>> +Positive values open the iris, negative close it.</entry> >>>>>> + </row> >>>>>> + <row><entry></entry></row> >>>>>> + >>>>>> + <row> >>>>>> + <entry >>>>>> spanname="id"><constant>V4L2_CID_IRIS_RELATIVE</constant> </entr >>>>>> y> + <entry>integer</entry> >>>>>> + </row><row><entry spanname="descr">This control modifies the >>>>>> +camera aperture's by the specified amount. The unit is undefined. >>>>>> +Positive values open the iris one step further, negative values >>>>>> close +it one step further. This is a write-only control.</entry> >>>>>> + </row> >>>>>> + <row><entry></entry></row> >>>>>> + >>>>>> + <row> >>>>>> >>>>>> <entry >>>>>> > spanname="id"><constant>V4L2_CID_PRIVACY</constant> </entr >>>>>> y> <entry>boolean</entry> >>>>>> >>>>>> </row><row><entry spanname="descr">Prevent video from being >>>>>> acquired >>>>> Seems ok to me, but it would be good to add some sort of scale for >>>>> those controls. >>>> I'd love to, but most iris controllers will just let you specify a >>>> value in an arbitrary scale (0 for closed, 255 for fully opened for >>>> instance). In that case do we want to force driver developers to >>>> measure the aperture in µm units with a micrometer caliper ? :-) >>> : >>> :) >>> >>> Well, maybe then you could just comment that higher values means more >>> opened apertures. >> Could point, I will do. > > I spoke too fast, it's already there :-) Oh. OK then ;) Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
