On 17. 07. 20, 11:01, Andy Shevchenko wrote: > On Thu, Jul 16, 2020 at 2:52 PM Jiri Slaby <jslaby@xxxxxxx> wrote: >> >> I am currently seeing: >> BUG: kernel NULL pointer dereference, address: 0000000000000002 >> ... >> Hardware name: UMAX VisionBook 10Wi Pro/CQM1018CWP, BIOS CQ1018.007 09/22/2016 >> RIP: 0010:gmin_subdev_add.cold+0x303/0x312 [atomisp_gmin_platform] >> ... >> Call Trace: >> gmin_camera_platform_data+0x2f/0x60 [atomisp_gmin_platform] >> ov2680_probe+0x7f/0x2b0 [atomisp_ov2680] >> i2c_device_probe+0x95/0x290 >> >> power can be NULL and that is properly handled earlier in this function. >> Even i2c address is set there. So this is a duplicated assignment which >> can cause the bug above. Remove it. > > I believe it's fixed in [1]. > > [1]: https://git.linuxtv.org/mchehab/experimental.git/log/?h=atomisp_v5 It seems so. By: commit 219448c9cd4a505b6274d746ca1897af20e6d06a Author: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Date: Fri Jun 26 14:19:21 2020 +0200 media: atomisp: Make pointer to PMIC client global thanks, -- js suse labs
