Re: [PATCHv3 1/7] videobuf2-v4l2.c: add vb2_video_unregister_device helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13/07/2020 17:55, Robert Foss wrote:
> Hey Hans,
> 
> Thanks for submitting this.
> 
>> If a driver calls (_)vb2_fop_release(), then such a driver should also
>> call vb2_video_unregister_device() instead of video_unregister_device().
>> This helper will all vb2_queue_release() if a filehandle is marked as
>> owner of the queue. This ensures that at unregister time any streaming
>> is cancelled and all buffers are returned to userspace.
> 
> Nit: "This helper will all vb2_queue_release()" wording is a bit confusing.
> 

Oops! all -> call

Regards,

	Hans



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux