Aguirre, Sergio wrote: > > >> -----Original Message----- >> From: Sakari Ailus [mailto:sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx] >> Sent: Wednesday, March 17, 2010 9:16 AM >> To: Laurent Pinchart >> Cc: Aguirre, Sergio; linux-media@xxxxxxxxxxxxxxx >> Subject: Re: [omap3camera] Camera bring-up on Zoom3 (OMAP3630) >> >> Laurent Pinchart wrote: >>>>>> I'm trying to get latest Sakari's tree (gitorious.org/omap3camera) >>>>>> 'devel' branch running on my Zoom3 HW (which has an OMAP3630, and a >>>>>> Sony IMX046 8MP sensor). >>>>>> >>>>>> I had first one NULL pointer dereference while the driver was >>>>>> registering devices and creating entities, which I resolved with >>>>>> the attached patch. (Is this patch acceptable, or maybe I am missing >>>>>> something...) >>>>> >>>>> Either that, or make OMAP34XXCAM_VIDEODEVS dynamic (the value would be >>>>> passed through platform data). The code will be removed (hopefully >> soon) >>>>> anyway when the legacy video nodes will disappear. >>>> >>>> Ok, so should I keep this patch only to myself until this code is >> removed? >>> >>> I'll let Sakari answer that, but I think they can still go in in the >> meantime. >> >> Is there a need for the patch? The other possible device is just left >> unused, right? > > There is need for it _if_ I don't change OMAP34XXCAM_VIDEODEVS in > drivers/media/video/omap34xxcam.h, and if I have less devices listed > in the platform data passed from the boardfile. > > In this case, OMAP34XXCAM_VIDEODEVS is hardcoded to N900 case, which is 2, > and I only have 1 sensor in my Zoom3. > > I guess the patch is just protecting for potential pointer dereferencing, unless we get rid of current OMAP34XXCAM_VIDEODEVS hardcoded value. What exactly does not work? The video devices are registered dynamically based on the number of sensors available so in this case the second video device is not even registered. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
