On Fri, Jul 3, 2020 at 5:39 PM Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > On 30/06/2020 08:27, Alexandre Courbot wrote: > > Add Mediatek's non-compressed 8 bit block video mode. This format is > > produced by the MT8183 codec and can be converted to a non-proprietary > > format by the MDP3 component. > > > > Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxxxx> > > --- > > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > > include/uapi/linux/videodev2.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > > index 02bfef0da76d..612be602bf76 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1398,6 +1398,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > > case V4L2_META_FMT_UVC: descr = "UVC Payload Header Metadata"; break; > > case V4L2_META_FMT_D4XX: descr = "Intel D4xx UVC Metadata"; break; > > case V4L2_META_FMT_VIVID: descr = "Vivid Metadata"; break; > > + case V4L2_PIX_FMT_MM21: descr = "Mediatek 8-bit block format"; break; > > Can you move this up so it comes after V4L2_PIX_FMT_KONICA420? Sure. > > This format should also be added to Documentation/userspace-api/media/v4l/pixfmt-reserved.rst. Added a description right next to the related MT21C format. Thanks for the review! Alex.
