Re: [PATCH v5 6/7] media: staging: rkisp1: allow quantization setting by userspace on the isp source pad

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dafna,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20200703]
[cannot apply to v5.8-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dafna-Hirschfeld/v4l2-add-support-for-colorspace-conversion-API-CSC-for-video-capture-and-subdevices/20200704-011401
base:   git://linuxtv.org/media_tree.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ca464639a1c9dd3944eb055ffd2796e8c2e7639f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/staging/media/rkisp1/rkisp1-isp.c:597:15: error: use of undeclared identifier 'RKISP1_ISP_SD_SRC'; did you mean 'RKISP1_RSZ_PAD_SRC'?
                               dir == RKISP1_ISP_SD_SRC)
                                      ^~~~~~~~~~~~~~~~~
                                      RKISP1_RSZ_PAD_SRC
   drivers/staging/media/rkisp1/rkisp1-common.h:47:2: note: 'RKISP1_RSZ_PAD_SRC' declared here
           RKISP1_RSZ_PAD_SRC,
           ^
   1 error generated.

vim +597 drivers/staging/media/rkisp1/rkisp1-isp.c

   562	
   563	/* ----------------------------------------------------------------------------
   564	 * Subdev pad operations
   565	 */
   566	
   567	static int rkisp1_isp_enum_mbus_code(struct v4l2_subdev *sd,
   568					     struct v4l2_subdev_pad_config *cfg,
   569					     struct v4l2_subdev_mbus_code_enum *code)
   570	{
   571		unsigned int i, dir;
   572		int pos = 0;
   573	
   574		if (code->pad == RKISP1_ISP_PAD_SINK_VIDEO) {
   575			dir = RKISP1_DIR_SINK;
   576		} else if (code->pad == RKISP1_ISP_PAD_SOURCE_VIDEO) {
   577			dir = RKISP1_DIR_SRC;
   578		} else {
   579			if (code->index > 0)
   580				return -EINVAL;
   581			code->code = MEDIA_BUS_FMT_FIXED;
   582			return 0;
   583		}
   584	
   585		if (code->index >= ARRAY_SIZE(rkisp1_isp_formats))
   586			return -EINVAL;
   587	
   588		for (i = 0; i < ARRAY_SIZE(rkisp1_isp_formats); i++) {
   589			const struct rkisp1_isp_mbus_info *fmt = &rkisp1_isp_formats[i];
   590	
   591			if (fmt->direction & dir)
   592				pos++;
   593	
   594			if (code->index == pos - 1) {
   595				code->code = fmt->mbus_code;
   596				if (fmt->pixel_enc == V4L2_PIXEL_ENC_YUV &&
 > 597				    dir == RKISP1_ISP_SD_SRC)
   598					code->flags =
   599						V4L2_SUBDEV_MBUS_CODE_CSC_QUANTIZATION;
   600				return 0;
   601			}
   602		}
   603	
   604		return -EINVAL;
   605	}
   606	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux