Hi Laurent,
On 01/07/2020 07:21, Laurent Pinchart wrote:
> Drivers may need to test if a fwnode is a graph endpoint. To avoid
> hand-written solutions that wouldn't work for all fwnode types, add a
> new fwnode_graph_is_endpoint() function for this purpose. We don't need
> to wire it up to different backends for OF and ACPI for now, as the
> implementation can simply be based on checkout the presence of a
> remote-endpoint property.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
Great, this makes the usage in [2/4] much more readable, and isolates
the internal knowledge of fw_node_properties where it should be.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> ---
> include/linux/property.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 10d03572f52e..9f805c442819 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -389,6 +389,11 @@ struct fwnode_handle *
> fwnode_graph_get_remote_node(const struct fwnode_handle *fwnode, u32 port,
> u32 endpoint);
>
> +static inline bool fwnode_graph_is_endpoint(struct fwnode_handle *fwnode)
> +{
> + return fwnode_property_present(fwnode, "remote-endpoint");
> +}
> +
> /*
> * Fwnode lookup flags
> *
>
