Hi Dafna,
On 6/26/20 5:51 AM, Dafna Hirschfeld wrote:
> The function 'rkisp1_stats_vb2_stop_streaming' runs in user context
> therefore it is enough to use spin_lock_irq
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>
Thanks,
Helen
> ---
> drivers/staging/media/rkisp1/rkisp1-stats.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-stats.c b/drivers/staging/media/rkisp1/rkisp1-stats.c
> index b19a6d9cdd4d..d4f0df4342e0 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-stats.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-stats.c
> @@ -152,13 +152,12 @@ static void rkisp1_stats_vb2_stop_streaming(struct vb2_queue *vq)
> {
> struct rkisp1_stats *stats = vq->drv_priv;
> struct rkisp1_buffer *buf;
> - unsigned long flags;
> unsigned int i;
>
> /* Make sure no new work queued in isr before draining wq */
> - spin_lock_irqsave(&stats->irq_lock, flags);
> + spin_lock_irq(&stats->irq_lock);
> stats->is_streaming = false;
> - spin_unlock_irqrestore(&stats->irq_lock, flags);
> + spin_unlock_irq(&stats->irq_lock);
>
> drain_workqueue(stats->readout_wq);
>
>
