On 26/06/2020 01:29, Helen Koike wrote:
>
>
> On 6/5/20 2:26 PM, Dafna Hirschfeld wrote:
<snip>
>> /*
>> * F O R M A T E N U M E R A T I O N
>> @@ -792,6 +793,9 @@ struct v4l2_fmtdesc {
>> #define V4L2_FMT_FLAG_EMULATED 0x0002
>> #define V4L2_FMT_FLAG_CONTINUOUS_BYTESTREAM 0x0004
>> #define V4L2_FMT_FLAG_DYN_RESOLUTION 0x0008
>> +#define V4L2_FMT_FLAG_CSC_YCBCR_ENC 0x0010
>> +#define V4L2_FMT_FLAG_CSC_HSV_ENC 0x0010
>
> Shouldn't those have different values? Or is this intentional?
It's intentional, but it would probably be better to write this as:
#define V4L2_FMT_FLAG_CSC_YCBCR_ENC 0x0010
#define V4L2_FMT_FLAG_CSC_HSV_ENC V4L2_FMT_FLAG_CSC_YCBCR_ENC
That makes it explicit that HSV_ENC is an alias for YCBCR_ENC.
Regards,
Hans
>
> Regards,
> Helen
>
>> +#define V4L2_FMT_FLAG_CSC_QUANTIZATION 0x0020
>>
>> /* Frame Size and frame rate enumeration */
>> /*
>>
