Hi Karthik, Thank you for the patch. On Thu, Jun 25, 2020 at 10:17:23PM -0400, B K Karthik wrote: > soc_camera.c: > > fixing ERROR: Macros with complex values must be enclused within parentheses. > > Signed-off-by: B K Karthik <karthik.bk2000@xxxxxxxx> > --- > drivers/staging/media/soc_camera/soc_camera.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/media/soc_camera/soc_camera.c b/drivers/staging/media/soc_camera/soc_camera.c > index 39f513f69b89..f609ecf6691c 100644 > --- a/drivers/staging/media/soc_camera/soc_camera.c > +++ b/drivers/staging/media/soc_camera/soc_camera.c > @@ -238,8 +238,7 @@ unsigned long soc_camera_apply_board_flags(struct soc_camera_subdev_desc *ssdd, > } > EXPORT_SYMBOL(soc_camera_apply_board_flags); > > -#define pixfmtstr(x) (x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, \ > - ((x) >> 24) & 0xff > +#define pixfmtstr(x) ((x) & 0xff, ((x) >> 8) & 0xff, ((x) >> 16) & 0xff, ((x) >> 24) & 0xff) This won't work. Try to compile this driver with CONFIG_DYNAMIC_DEBUG and the compiler will tell you why. Regardless, drivers/staging/media/soc_camera/soc_camera.c is in staging because it will be removed from the kernel, cleanups for this file won't be accepted. > static int soc_camera_try_fmt(struct soc_camera_device *icd, > struct v4l2_format *f) -- Regards, Laurent Pinchart
