Hi Tomasz, On 2020-06-24 4:58 a.m., Tomasz Figa wrote: > On Wed, Jun 24, 2020 at 1:54 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >> >> On Wed, Jun 24, 2020 at 01:39:50PM +0200, Hans Verkuil wrote: >>> Can someone from Samsung or someone who knows this SoC take a look at this series? >>> >>> This series looks sane to me, so I'll probably merge this if nobody replies >>> in the next two weeks or so. >> >> Unfortunately I don't know the media part on S5Pv210 at all so I cannot >> provide any feedback. There are not many active users of these SoCs >> nowadays. One of hem is Jonathan, so if he wants to change something he will >> mostly break/affect his own setup. :) Therefore I think it is safe to merge. > > I think this driver is also used on Exynos4210 and on some setups with > 4412 where the ISP is not used. Yes, this driver is also used by Exynos4210 and Exynos4412, notably by the Galaxy S3 series. They don't use the parallel ports, but rather the CSIS. I don't believe I've broken support for that, but I don't have the hardware to test. My other remaining concern is whether to adjust the camera port A/camera port B to match the device tree documentation or to update the documentation to match the driver. I decided to update the driver in these patches, but it is much simpler to simply update the binding doc. The only mainline user of the parallel ports is the Goni dev board which appears to be setup for the driver way of numbering as opposed to the binding doc. I have no strong preference on which way to actually go. > > I can't promise anything, but I'll try to do a high level review. > Hopefully I still have some memory from the time I used to play with > this hardware. Thanks, that would be appreciated, Jonathan > > Best regards, > Tomasz >
