Hello,
thanks for your helpful suggestions. I made a PR from those: Feel free
to squash it into yours:
https://gitlab.com/adalessandro/v4l-utils/-/merge_requests/1
When looking at your quoted code with the fixes I'm wondering if you
forgot to push your branch?
On 6/23/20 7:26 PM, Ariel D'Alessandro wrote:
On 6/22/20 4:09 PM, Gregor Jasny wrote:
I noticed the following:
* library symlinks are not in place
see https://packages.debian.org/sid/amd64/libv4l-0/filelist
Right. Each library target should have soversion and version set in order to
create the proper symlinks. As follows:
BTW, shall we set these fields in meson with the proper version tag?
I don't think so because v4l-utils feels more like a mono-repo. Each
library is versioned independently.
I have some more comments:
* The project version is still at 1.19.0 (should be 1.21.0 for the merge)
* As long as we support autotools and use 'make dist' to create the
tarball we'd have to add the meson.build and meson_options.txt to the
EXTRA_DIST of the respective Makefile.am.
* for ir-keytable the following variables are set and forwarded to the
source code as a preprocessor define:
ir_keytable_system_dir = udevdir
ir_keytable_user_dir = get_option('sysconfdir') / 'rc_keymaps'
It would be nice if we could re-use those as the install-dir base here:
udevdir / 'rc_keymaps'
(But that's nice to have)
* Right now on install we create an empty directory at the
ir_keytable_user_dir. Are you aware of any mechanism to create this with
meson? I found https://github.com/mesonbuild/meson/issues/2904 and it
makes me think that there is no easy way to do so. I could imaging to
work-around by putting a readme file inside of that directory to have it
created. That would also explain its reason for existence.
I'm still very fascinated of the very high build speed improvement. For
me it's down to 8s (with cold cache). Very impressive. Thank you, again!
Thanks,
Gregor
