Re: [GIT PATCHES FOR 2.6.34] gspca development

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean,

It seems that some of the patches are for 2.6.34 and some for 2.6.35 (changes of an
existing driver in preparation for a new driver should be added during a merge window). 

Could you please break them into two separate pull requests? The patches for 2.6.34 will
be added at the fixes.git tree, while the others will go to the v4l-dvb.git tree.

Jean-Francois Moine wrote:
> The following changes since commit
> ac8b45fc29b7dc4837c9b541033b62305fdccb85: Max Thrun (1):
>         V4L/DVB: gspca - ov534: Update copyright info
> 
> are available in the git repository at:
> 
>   git://linuxtv.org/jfrancois/gspca.git devel
> 
> Erik Andrén (1):
>       gspca - stv06xx: Remove the 046d:08da from the stv06xx driver.

OK for 2.6.34.
> 
> Olivier Lorin (2):
>       gspca - gl860: Updates to prepare the new driver for MI2020 sensor.

Better to delay to 2.6.35, since this changes the behavior of the driver.

- General changes for all drivers because of new MI2020 sensor driver :
  - add the light source control
  - control value changes only applied after an end of image
  - replace msleep with duration less than 5 ms by a busy loop
- Fix for an irrelevant OV9655 image resolution identifier name

The better is to break it into 4 patches (one for each different logical change).

In the case of this change:
  - replace msleep with duration less than 5 ms by a busy loop

Keeping the cpu hold for 5 ms is not a good idea, except if you have a
reason for doing that. Long delays will spend more power, and will keep
cpu running during all the time the delay will happen. That's why mdelay()
is used only in the cases where the delay timing is critical. 

In this case, you should write a separate patch with this change, clearly 
stating why this is needed. 

Also, if this change is needed just because mi2020 driver, you shouldn't be
applying penalty to users with other sensors.

>       gspca - gl860: New driver for MI2020 sensor.

Better to delay to 2.6.35, since this changes the behavior of the driver.

> 
> Yong Zhang (1):
>       gspca - sn9c20x: Correct onstack wait_queue_head declaration.

OK for 2.6.34.

-- 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux