Hi Tomasz, Thanks for the review. On Thu, 2020-06-18 at 19:13 +0000, Tomasz Figa wrote: > Hi Dongchun, > > On Mon, Jun 15, 2020 at 08:29:36PM +0800, Dongchun Zhu wrote: > > Add DT bindings documentation for Omnivision OV02A10 image sensor. > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > --- > > .../bindings/media/i2c/ovti,ov02a10.yaml | 171 +++++++++++++++++++++ > > MAINTAINERS | 7 + > > 2 files changed, 178 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > Thank you for the patch. Please see my comments inline. > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > new file mode 100644 > > index 0000000..f84be1b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > @@ -0,0 +1,171 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +# Copyright (c) 2020 MediaTek Inc. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov02a10.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Omnivision OV02A10 CMOS Sensor Device Tree Bindings > > + > > +maintainers: > > + - Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > + > > +description: |- > > + The Omnivision OV02A10 is a low-cost, high performance, 1/5-inch, 2 megapixel > > + image sensor, which is the latest production derived from Omnivision's CMOS > > + image sensor technology. Ihis chip supports high frame rate speeds up to 30fps > > + @ 1600x1200 (UXGA) resolution transferred over a 1-lane MIPI interface. The > > + sensor output is available via CSI-2 serial data output. > > + > > +properties: > > + compatible: > > + const: ovti,ov02a10 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: top mux camtg clock > > + - description: divider clock > > + > > + clock-names: > > + items: > > + - const: eclk > > + - const: freq_mux > > + > > + clock-frequency: > > + description: > > + Frequency of the eclk clock in Hertz. > > + > > + dovdd-supply: > > + description: > > + Definition of the regulator used as Digital I/O voltage supply. > > + > > + avdd-supply: > > + description: > > + Definition of the regulator used as Analog voltage supply. > > + > > + dvdd-supply: > > + description: > > + Definition of the regulator used as Digital core voltage supply. > > + > > + powerdown-gpios: > > + description: > > + Must be the device tree identifier of the GPIO connected to the > > + PD_PAD pin. This pin is used to place the OV02A10 into Standby mode > > + or Shutdown mode. As the line is active low, it should be > > + marked GPIO_ACTIVE_LOW. > > This line is not active low. It needs to be high for the powerdown mode > to be active. > Sorry, I made a misunderstanding of the real meaning of 'line active'. For PD_PAD pin, 'effective' means 'sensor is shut down'. Yes, it's a 'shut down' signal, not a 'enable' signal. > > + maxItems: 1 > > + > > + reset-gpios: > > + description: > > + Must be the device tree identifier of the GPIO connected to the > > + RST_PD pin. If specified, it will be asserted during driver probe. > > + As the line is active high, it should be marked GPIO_ACTIVE_HIGH. > > This line is not active high. It needs to be low for the reset to be > active. > Fixed in next release. > Best regards, > Tomasz
