Kieran Bingham, Thu, Jun 18, 2020 18:32:55 +0200: > On 02/04/2020 19:35, Alex Riesen wrote: > > --- a/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > > @@ -146,7 +146,8 @@ &sata { > > &sound_card { > > dais = <&rsnd_port0 /* ak4613 */ > > &rsnd_port1 /* HDMI0 */ > > - &rsnd_port2>; /* HDMI1 */ > > + &rsnd_port2 /* HDMI1 */ > > + &rsnd_port3>; /* adv7482 hdmi-in */ > > Ah - that was confusing at first... but HDMI0 and HDMI1 are *outputs*, > where of course the adv7482 is an input ;-) And ak4613 is both... Why? Are the "dais" of a sound_card more commonly outputs than inputs? > Otherwise, I can't spot anything else yet so: > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > But I fear there may have been some churn around here, so it would be > good to see a rebase too. Just rebased the series on top of linux-media/master and the only conflict was in adding ssi4 node to rcar_sound,ssi in r8a77961.dtsi, as there was an addition of ssi2 in the same line. Thanks, Alex