Hi Laurent,
Thanks you for the patch.
Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote on Mon [2020-Jun-15 02:58:27 +0300]:
> Use the dev_* print macros instead of the v4l2_* print macros. This
> prepares for a common print infrastructure that will also support the
> cal_camerarx instances.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/ti-vpe/cal.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
> index e40967751aa4..e62089832713 100644
> --- a/drivers/media/platform/ti-vpe/cal.c
> +++ b/drivers/media/platform/ti-vpe/cal.c
> @@ -53,19 +53,22 @@ static unsigned debug;
> module_param(debug, uint, 0644);
> MODULE_PARM_DESC(debug, "activates debug info");
>
> -#define cal_dbg(level, cal, fmt, arg...) \
> - v4l2_dbg(level, debug, &cal->v4l2_dev, fmt, ##arg)
> +#define cal_dbg(level, cal, fmt, arg...) \
> + do { \
> + if (debug >= (level)) \
> + dev_dbg(&(cal)->pdev->dev, fmt, ##arg); \
> + } while (0)
The problem here with using dev_dbg is that you loose the ability to enable
or disable debug log at runtime. Which I find highly convenient.
With dev_dbg you have to compile with DEBUG defined or at the very least
DYNAMIC_DEBUG.
Benoit
> #define cal_info(cal, fmt, arg...) \
> - v4l2_info(&cal->v4l2_dev, fmt, ##arg)
> + dev_info(&(cal)->pdev->dev, fmt, ##arg)
> #define cal_err(cal, fmt, arg...) \
> - v4l2_err(&cal->v4l2_dev, fmt, ##arg)
> + dev_err(&(cal)->pdev->dev, fmt, ##arg)
>
> #define ctx_dbg(level, ctx, fmt, arg...) \
> - v4l2_dbg(level, debug, &ctx->v4l2_dev, fmt, ##arg)
> + cal_dbg(level, (ctx)->cal, "ctx%u: " fmt, (ctx)->csi2_port, ##arg)
> #define ctx_info(ctx, fmt, arg...) \
> - v4l2_info(&ctx->v4l2_dev, fmt, ##arg)
> + cal_info((ctx)->cal, "ctx%u: " fmt, (ctx)->csi2_port, ##arg)
> #define ctx_err(ctx, fmt, arg...) \
> - v4l2_err(&ctx->v4l2_dev, fmt, ##arg)
> + cal_err((ctx)->cal, "ctx%u: " fmt, (ctx)->csi2_port, ##arg)
>
> #define CAL_NUM_CONTEXT 2
>
> --
> Regards,
>
> Laurent Pinchart
>
