On Thu, Jun 18, 2020 at 01:35:16PM +0200, Dafna Hirschfeld wrote: > The macro RKISP1_DIR_SINK_SRC is a mask of two flags. > The macro hides the fact that it's a mask and the code > is actually more clear if we replace it the with bitwise-or explicitly. > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> > Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx> > --- > drivers/staging/media/rkisp1/rkisp1-isp.c | 25 +++++++++++------------ > 1 file changed, 12 insertions(+), 13 deletions(-) > Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx> Best regards, Tomasz