Hi Dafna, Thanks for the patch. On 6/13/20 6:13 AM, Dafna Hirschfeld wrote: > Add documentation for the struct rkisp1_isp_mbus_info with > one line doc of each field > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> > --- > drivers/staging/media/rkisp1/rkisp1-common.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-common.h b/drivers/staging/media/rkisp1/rkisp1-common.h > index 13c5eeff66f3..6104eddac0e5 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-common.h > +++ b/drivers/staging/media/rkisp1/rkisp1-common.h > @@ -268,6 +268,19 @@ struct rkisp1_device { > struct rkisp1_debug debug; > }; > > +/* > + * struct rkisp1_isp_mbus_info > + * > + * holds information about the supported isp media bus > + * @mbus_code: the media bus code > + * @pixel_enc: the pixel encoding > + * @mipi_dt: the mipi data type > + * @yuv_seq: the order of the yuv values for yuv formats > + * @bus_width: the bus width > + * @bayer_pat: the bayer pattern for bayer formats > + * @isp_pads_mask: a bitmask of the pads that the format is supported on > + */ > + > /* > * struct rkisp1_isp_mbus_info - ISP pad format info > * > Why doesn't it remove the current doc? Thanks Helen