Re: [patch 1/5] drivers/media/video/cx23885 needs kfifo conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2010-03-13 at 13:59 +0100, Stefani Seibold wrote:
> Am Donnerstag, den 11.03.2010, 14:02 -0800 schrieb
> akpm@xxxxxxxxxxxxxxxxxxxx:
> > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > 
> > linux-next:
> > 
> > drivers/media/video/cx23885/cx23888-ir.c: In function 'cx23888_ir_irq_handler':
> > drivers/media/video/cx23885/cx23888-ir.c:597: error: implicit declaration of function 'kfifo_put'
> > drivers/media/video/cx23885/cx23888-ir.c: In function 'cx23888_ir_rx_read':
> > drivers/media/video/cx23885/cx23888-ir.c:660: error: implicit declaration of function 'kfifo_get'
> > drivers/media/video/cx23885/cx23888-ir.c: In function 'cx23888_ir_probe':
> > drivers/media/video/cx23885/cx23888-ir.c:1172: warning: passing argument 1 of 'kfifo_alloc' makes pointer from integer without a cast
> > drivers/media/video/cx23885/cx23888-ir.c:1172: warning: passing argument 3 of 'kfifo_alloc' makes integer from pointer without a cast
> > drivers/media/video/cx23885/cx23888-ir.c:1172: warning: assignment makes pointer from integer without a cast
> > drivers/media/video/cx23885/cx23888-ir.c:1178: warning: passing argument 1 of 'kfifo_alloc' makes pointer from integer without a cast
> > drivers/media/video/cx23885/cx23888-ir.c:1178: warning: passing argument 3 of 'kfifo_alloc' makes integer from pointer without a cast
> > drivers/media/video/cx23885/cx23888-ir.c:1178: warning: assignment makes pointer from integer without a cast
> > 
> 
> This looks fine in 2.6.33. I don't know who reverted it in linux-next.
> 

Things also look OK at the v4l-dvb GIT repositories:

http://git.linuxtv.org/v4l-dvb.git?a=blob;f=drivers/media/video/cx23885/cx23888-ir.c;hb=HEAD

http://git.linuxtv.org/linux-2.6.git?a=blob;f=drivers/media/video/cx23885/cx23888-ir.c;hb=HEAD

As far as I recall, this file should not have changed since the original
changes for the new kfifo implementation.

Regards,
Andy


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux