On 21/05/2020 12:05, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> ---
> drivers/media/platform/sti/hva/hva-hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c
> index 401aaafa1710..8533d3bc6d5c 100644
> --- a/drivers/media/platform/sti/hva/hva-hw.c
> +++ b/drivers/media/platform/sti/hva/hva-hw.c
> @@ -388,7 +388,7 @@ int hva_hw_probe(struct platform_device *pdev, struct hva_dev *hva)
> ret = pm_runtime_get_sync(dev);
> if (ret < 0) {
> dev_err(dev, "%s failed to set PM\n", HVA_PREFIX);
> - goto err_clk;
> + goto err_pm;
> }
>
> /* check IP hardware version */
>
err_pm:
pm_runtime_put(dev);
Shouldn't that be pm_runtime_put_sync()?
I'm not pm expert, but it does look odd.
Regards,
Hans
