Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/28/2020 1:06 AM, Rob Herring wrote:
On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote:
Add an optional power domain which when specified can be used for
setting the performance state of Venus.

Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
---
  Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml    | 6 +++++-
  Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
  2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
index 764affa..ac1ed64 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
@@ -25,12 +25,16 @@ properties:
      maxItems: 1
power-domains:
-    maxItems: 2
+    minItems: 2
+    maxItems: 3
power-domain-names:
+    minItems: 2
+    maxItems: 3
      items:
        - const: venus
        - const: vcodec0
+      - const: opp-pd

Humm, looks suspicious. This is a phyical power island in this block?

yes, this is used to represent the physical 'cx' power island in the SoC
(Its a shared power island, not a power island specific to this block)
that can be scaled to different 'performance levels' based on the frequency
the codec is expected to run at.

Because that's what 'power-domains' are supposed to represent. Not $os
pm-domain construct.

Rob


--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux