Em Wed, 27 May 2020 09:45:21 -0700 Nathan Chancellor <natechancellor@xxxxxxxxx> escreveu: > On Wed, May 27, 2020 at 10:45:25AM +0200, Mauro Carvalho Chehab wrote: > > Em Wed, 27 May 2020 00:11:43 -0700 > > Nathan Chancellor <natechancellor@xxxxxxxxx> escreveu: > > > > > Hi all, > > > > > > This series aims to clean up the code while addressing the majority of > > > clang warnings in this driver, some found by the 0day bot and others > > > found by me. > > > > > > There are several enum conversion warnings that happen, which I do not > > > really know how to solve without understanding how exactly this driver > > > works. I would appreciate some guidance or a solution. Below are the > > > warnings, sorry for not wrapping them but they would be hard to read > > > otherwise. > > > > ... > > > ../drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:117:22: note: expanded from macro 'CSS_ID' > > > #define CSS_ID(val) (IA_ ## val) > > ... > > > > I actually wrote a patch getting rid of this ugly thing: > > > > https://git.linuxtv.org/mchehab/experimental.git/commit/?h=atomisp_v3&id=cf6a15543ace1e99364911c0b7a2f6b8f2f43021 > > > > This one was already submitted upstream (not merged yet), but there > > are also lots of other patches on my working tree. > > Ah excellent, that makes the warnings a lot more readable. I am still > not sure how to reconcile the differences, it might be easier to just > change the types in the struct to int. > > ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:49:68: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] > { V4L2_MBUS_FMT_CUSTOM_NV21, 12, 12, IA_CSS_FRAME_FORMAT_NV21, 0, IA_CSS_FRAME_FORMAT_NV21 }, > ~ ^~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:49:39: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] > { V4L2_MBUS_FMT_CUSTOM_NV21, 12, 12, IA_CSS_FRAME_FORMAT_NV21, 0, IA_CSS_FRAME_FORMAT_NV21 }, > ~ ^~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:48:68: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] > { V4L2_MBUS_FMT_CUSTOM_NV12, 12, 12, IA_CSS_FRAME_FORMAT_NV12, 0, IA_CSS_FRAME_FORMAT_NV12 }, > ~ ^~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:48:39: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] > { V4L2_MBUS_FMT_CUSTOM_NV12, 12, 12, IA_CSS_FRAME_FORMAT_NV12, 0, IA_CSS_FRAME_FORMAT_NV12 }, > ~ ^~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/staging/media/atomisp/pci/atomisp_subdev.c:47:34: warning: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Wenum-conversion] > { MEDIA_BUS_FMT_JPEG_1X8, 8, 8, IA_CSS_FRAME_FORMAT_BINARY_8, 0, ATOMISP_INPUT_FORMAT_BINARY_8 }, > ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 5 warnings generated. Well, I guess we should just get rid of the duplication there, > > > I'll try to apply your patch series on it, once I'll be able to > > fix a bug with mmap support. > > It looks like all of them apply to your experimental branch aside from > patch 3, which you handled in a different way. Ok. I'll apply your patch series on my tree. Thanks, Mauro
