Hi, On Wed, May 20, 2020 at 03:16:24PM +0900, Takashi Sakamoto wrote: > Hi, > > I'm an author of ALSA firewire stack and thanks for the patch. I agree with > your intention to remove the cast of function callback toward CFI build. > > Practically, the isochronous context with FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL > is never used by in-kernel drivers. Here, I propose to leave current > kernel API (fw_iso_context_create() with fw_iso_callback_t) as is. > Alternatively, a new kernel API for the context (e.g. > fw_iso_mc_context_create() with fw_iso_mc_callback_t). This idea leaves > current drivers as is and the change is done inner firewire-core driver, > therefore existent kernel API is not changed. > It sounds good to me. > Later I post two patches for the proposal. I'd like you to review it and > I'm glad to receive your comments. > I will take a look at your proposal. Thanks for your time and work. > > Regards > > Takashi Sakamoto Thanks, Oscar Carter
