Manu Abraham wrote: > Mauro, > > Please pull from http://jusst.de/hg/mantis-v4l-dvb This tree also needs rebase. Some of the patches were already applied: # Mercurial patches imported from http://jusst.de/hg/mantis-v4l-dvb hg_14410_stv090x_code_simplification.patch hg_14411_stv090x_stv6110x_use_tuner_sleep_within_the_demodulator_control.patch hg_14412_stv090x_use_gate_control_while_tuner_is_being_accessed.patch hg_14413_budget_stv090x_stv6110x_initialize_the_demodulator_immediately_after.patch hg_14414_stv090x_add_some_notes_about_the_internal_tuner_i_o_control.patch hg_14415_mantis_remote_control_for_mantis.patch hg_14416_mantis_hopper_use_module_device_table.patch hg_14417_mantis_hopper_do_not_unregister_modules_twice.patch Also, if just the last 3 patches are applied, lots of checkpacth errors are produced: WARNING: line over 80 characters #172: FILE: drivers/media/dvb/mantis/mantis_cards.c:223: + dprintk(MANTIS_ERROR, 1, "ERROR: Mantis INPUT initialization failed <%d>", err); WARNING: line over 80 characters #355: FILE: drivers/media/dvb/mantis/mantis_dvb.c:292: + mantis->demux.dmx.remove_frontend(&mantis->demux.dmx, &mantis->fe_mem); WARNING: line over 80 characters #356: FILE: drivers/media/dvb/mantis/mantis_dvb.c:293: + mantis->demux.dmx.remove_frontend(&mantis->demux.dmx, &mantis->fe_hw); ERROR: trailing whitespace #489: FILE: drivers/media/dvb/mantis/mantis_input.c:57: +^Isnprintf(mir->rc_name, sizeof(mir->rc_name), $ ERROR: code indent should use tabs where possible #490: FILE: drivers/media/dvb/mantis/mantis_input.c:58: +^I "Mantis %s IR Receiver", mantis->hwconfig->model_name);$ ERROR: trailing whitespace #491: FILE: drivers/media/dvb/mantis/mantis_input.c:59: +^Isnprintf(mir->rc_phys, sizeof(mir->rc_phys), $ ERROR: code indent should use tabs where possible #492: FILE: drivers/media/dvb/mantis/mantis_input.c:60: +^I "pci-%s/ir0", pci_name(mantis->pdev));$ WARNING: line over 80 characters #499: FILE: drivers/media/dvb/mantis/mantis_input.c:64: + dprintk(MANTIS_ERROR, 1, "Input device %s PCI: %s", mir->rc_name, mir->rc_phys); WARNING: line over 80 characters #551: FILE: drivers/media/dvb/mantis/mantis_input.c:105: + dprintk(MANTIS_ERROR, 0, "RC Input Sendkey:%d <%02x>\n", i, buf[i]); ERROR: space required before the open parenthesis '(' #588: FILE: drivers/media/dvb/mantis/mantis_uart.c:106: + if(config->uart_work) { WARNING: braces {} are not necessary for single statement blocks #588: FILE: drivers/media/dvb/mantis/mantis_uart.c:106: + if(config->uart_work) { + config->uart_work(mantis, buf); + } ERROR: code indent should use tabs where possible #592: FILE: drivers/media/dvb/mantis/mantis_uart.c:110: + /* reenable interrupt */$ ERROR: code indent should use tabs where possible #593: FILE: drivers/media/dvb/mantis/mantis_uart.c:111: + mmwrite(mmread(MANTIS_INT_MASK) | 0x800, MANTIS_INT_MASK);$ ERROR: code indent should use tabs where possible #594: FILE: drivers/media/dvb/mantis/mantis_uart.c:112: + mmwrite(mmread(MANTIS_UART_CTL) | MANTIS_UART_RXINT, MANTIS_UART_CTL);$ WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #670: FILE: drivers/media/dvb/mantis/mantis_vp1041.c:102: +EXPORT_SYMBOL_GPL(ir_codes_mantis_vp1041_table); WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #767: FILE: drivers/media/dvb/mantis/mantis_vp2033.c:107: +EXPORT_SYMBOL_GPL(ir_codes_mantis_vp2033_table); WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #850: FILE: drivers/media/dvb/mantis/mantis_vp2040.c:93: +EXPORT_SYMBOL_GPL(ir_codes_mantis_vp2040_table); total: 8 errors, 9 warnings, 798 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. -- Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
