On Wed, 6 May 2020 at 13:03, Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote: > > The IMX219 camera driver is not a clock provider, but merely a clock > consumer, and thus does not need to include <linux/clk-provider.h> and > <linux/clkdev.h>. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> I'm no expert on the clock frameworks, but that seems logical. Acked-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> The same appears to be true for drivers/media/i2c/ov5640.c unless it's been fixed since 5.7-rc5. > --- > drivers/media/i2c/imx219.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index cb03bdec1f9c8954..078f2093d881d7c2 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -15,8 +15,6 @@ > */ > > #include <linux/clk.h> > -#include <linux/clk-provider.h> > -#include <linux/clkdev.h> > #include <linux/delay.h> > #include <linux/gpio/consumer.h> > #include <linux/i2c.h> > -- > 2.17.1 >