On Mon, May 11, 2020 at 5:20 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, Apr 24, 2020 at 01:38:18AM -0400, Jeff Chase wrote: > > The ch7322 is a Chrontel CEC controller. > > > > Signed-off-by: Jeff Chase <jnchase@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > index 4165352a590a..ec2ddc6cdf9a 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > @@ -48,6 +48,8 @@ properties: > > - capella,cm32181 > > # CM3232: Ambient Light Sensor > > - capella,cm3232 > > + # CH7322: HDMI-CEC Controller > > + - chrontel,ch7322 > > I don't think this qualifies as a trivial device. It has HPDI, OE and > reset signals all likely hooked up to GPIOs. You might not have those > hooked up for s/w control, but someone will. > > And I'd assume if you had multiple instances, they will need to be > associated with each connector. > > Rob Thank you for looking at this. Taking a step back for a moment, I am developing this driver for an x86/ACPI platform on which I also control the firmware. Is there a preference between using an ACPI ID and a devicetree compatible id? I am trying to find out if the vendor already has an ACPI ID for this device. If I find and use that should I still add a compatible id anyways? Jeff
