Re: [PATCH 7/7] utils: switch C to C++ headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 5, 2020 at 1:55 AM Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>
> On 29/04/2020 06:06, Rosen Penev wrote:
> > Recently, I changed exit() to the std variant, which caused build
> > failures on older platforms. Switch all headers to the C++ variants
> > to avoid this.
> >
> > These C headers are deprecated by C++14.
>
> What failures exactly? And on what platforms?
Maybe all.

std::exit needs cstdlib.

Build failure was privately reported to me for Ubuntu 18.04.
>
> This patch changes a lot of files, and I'd like to have a bit more
> information before applying this.
>
> I'll commit patches 5 and 6 of this series, but please repost the
> others with better commit logs that help me understand the reason
> for the change.
>
> Regards,
>
>         Hans
>
> >
> > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> > ---
> >  utils/cec-compliance/cec-compliance.cpp          | 10 +++++-----
> >  utils/cec-compliance/cec-test-adapter.cpp        | 10 +++++-----
> >  utils/cec-compliance/cec-test-audio.cpp          | 10 +++++-----
> >  utils/cec-compliance/cec-test-fuzzing.cpp        | 10 +++++-----
> >  utils/cec-compliance/cec-test-power.cpp          | 10 +++++-----
> >  utils/cec-compliance/cec-test.cpp                |  8 ++++----
> >  utils/cec-ctl/cec-ctl.cpp                        | 10 +++++-----
> >  utils/cec-ctl/cec-pin.cpp                        | 12 ++++++------
> >  utils/cec-follower/cec-follower.cpp              |  8 ++++----
> >  utils/cec-follower/cec-processing.cpp            | 10 +++++-----
> >  utils/cec-follower/cec-tuner.cpp                 |  2 +-
> >  utils/common/media-info.cpp                      | 10 +++++-----
> >  utils/common/v4l2-info.cpp                       | 10 +++++-----
> >  utils/libcecutil/cec-info.cpp                    |  2 +-
> >  utils/libcecutil/cec-log.cpp                     |  8 ++++----
> >  utils/libcecutil/cec-parse.cpp                   | 10 +++++-----
> >  utils/rds-ctl/rds-ctl.cpp                        | 14 +++++++-------
> >  utils/v4l2-compliance/v4l2-compliance.cpp        | 12 ++++++------
> >  utils/v4l2-compliance/v4l2-test-buffers.cpp      | 10 +++++-----
> >  utils/v4l2-compliance/v4l2-test-codecs.cpp       | 12 ++++++------
> >  utils/v4l2-compliance/v4l2-test-colors.cpp       | 12 ++++++------
> >  utils/v4l2-compliance/v4l2-test-controls.cpp     | 10 +++++-----
> >  utils/v4l2-compliance/v4l2-test-debug.cpp        | 12 ++++++------
> >  utils/v4l2-compliance/v4l2-test-formats.cpp      | 12 ++++++------
> >  utils/v4l2-compliance/v4l2-test-input-output.cpp | 10 +++++-----
> >  utils/v4l2-compliance/v4l2-test-io-config.cpp    | 10 +++++-----
> >  utils/v4l2-compliance/v4l2-test-media.cpp        | 12 ++++++------
> >  utils/v4l2-compliance/v4l2-test-subdevs.cpp      | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-common.cpp               | 10 +++++-----
> >  utils/v4l2-ctl/v4l2-ctl-edid.cpp                 |  8 ++++----
> >  utils/v4l2-ctl/v4l2-ctl-io.cpp                   | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-meta.cpp                 | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-misc.cpp                 | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-modes.cpp                |  4 ++--
> >  utils/v4l2-ctl/v4l2-ctl-overlay.cpp              | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-sdr.cpp                  | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-selection.cpp            | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-stds.cpp                 | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-streaming.cpp            | 10 +++++-----
> >  utils/v4l2-ctl/v4l2-ctl-subdev.cpp               | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-tuner.cpp                | 10 +++++-----
> >  utils/v4l2-ctl/v4l2-ctl-vbi.cpp                  | 10 +++++-----
> >  utils/v4l2-ctl/v4l2-ctl-vidcap.cpp               | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl-vidout.cpp               | 12 ++++++------
> >  utils/v4l2-ctl/v4l2-ctl.cpp                      | 12 ++++++------
> >  utils/v4l2-dbg/v4l2-dbg.cpp                      | 10 +++++-----
> >  46 files changed, 236 insertions(+), 236 deletions(-)
>



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux