Em Tue, 5 May 2020 10:33:00 +0200
Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> The following changes since commit e51759f56d314d28c25be7606b03791f048e44c7:
>
> media: v4l2-ctrls.h: clarify the p_def argument of v4l2_ctrl_new_std_compound (2020-04-29 12:04:58 +0200)
>
> are available in the Git repository at:
>
> git://linuxtv.org/hverkuil/media_tree.git tags/br-tegra
>
> for you to fetch changes up to 0bba0154ded02babccd59e21c6a27c5ad7d50faf:
>
> MAINTAINERS: Add Tegra Video driver section (2020-05-05 10:26:05 +0200)
>
> ----------------------------------------------------------------
> Tag branch
>
> ----------------------------------------------------------------
> Sowjanya Komatineni (2):
> media: tegra: Add Tegra210 Video input driver
> MAINTAINERS: Add Tegra Video driver section
As pointed by checkpatch:
WARNING: DT compatible string "nvidia,tegra210-csi" appears un-documented -- check ./Documentation/devicetree/bindings/
#628: FILE: drivers/staging/media/tegra-video/csi.c:521:
+ { .compatible = "nvidia,tegra210-csi", .data = &tegra210_csi_soc },
WARNING: DT compatible string "nvidia,tegra210-csi" appears un-documented -- check ./Documentation/devicetree/bindings/
#3238: FILE: drivers/staging/media/tegra-video/video.c:106:
+ { .compatible = "nvidia,tegra210-csi", },
and double-checked with:
$ git grep "nvidia,tegra210-csi"
drivers/staging/media/tegra-video/csi.c: { .compatible = "nvidia,tegra210-csi", .data = &tegra210_csi_soc },
drivers/staging/media/tegra-video/video.c: { .compatible = "nvidia,tegra210-csi", },
The DT specs for this driver are missing. I even checked at linux-next:
there's no DT bindings for this.
While the code sounds ok, I'll reject this PR. Please submit a new one
together with the DT file properly reviewed by DT maintainers.
Thanks,
Mauro
