Hi Sakari
getting to v4 for such a trivial change is a bit embarassing -.-'
On Wed, Apr 29, 2020 at 12:35:02AM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Tue, Apr 28, 2020 at 11:09:03PM +0200, Jacopo Mondi wrote:
> > +static int imx219_get_selection(struct v4l2_subdev *sd,
> > + struct v4l2_subdev_pad_config *cfg,
> > + struct v4l2_subdev_selection *sel)
> > +{
> > + struct imx219 *imx219 = to_imx219(sd);
> > + const struct v4l2_rect *__crop;
> > + int ret = 0;
>
> ret is unused.
>
ouch, sorry this was trivial.
> > +
> > + if (sel->pad != 0)
> > + return -EINVAL;
>
> As you only have a single pad (0), this check is redundant --- the caller
> will have done that check already.
>
I see, makes sense to remove it indeed
v4 on its way, maybe this time I can get it right
