tree: git://linuxtv.org/media_tree.git master
head: a349d3d97ea2d532a9c2d7211272623a4f71e8d0
commit: 4d0b43804c1245c63b5f87d89d14affc2195336f [235/274] media: staging: rkisp1: remove mbus field from rkisp1_sensor_async
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 4d0b43804c1245c63b5f87d89d14affc2195336f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Note: the linuxtv-media/master HEAD a349d3d97ea2d532a9c2d7211272623a4f71e8d0 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/staging/media/rkisp1/rkisp1-isp.c: In function 'rkisp1_config_isp':
>> drivers/staging/media/rkisp1/rkisp1-isp.c:294:14: error: 'struct rkisp1_sensor_async' has no member named 'mbus'
294 | if (sensor->mbus.type == V4L2_MBUS_BT656)
| ^~
vim +294 drivers/staging/media/rkisp1/rkisp1-isp.c
d65dd85281fbf7f Helen Koike 2020-01-08 269
d65dd85281fbf7f Helen Koike 2020-01-08 270 /*
d65dd85281fbf7f Helen Koike 2020-01-08 271 * configure ISP blocks with input format, size......
d65dd85281fbf7f Helen Koike 2020-01-08 272 */
d65dd85281fbf7f Helen Koike 2020-01-08 273 static int rkisp1_config_isp(struct rkisp1_device *rkisp1)
d65dd85281fbf7f Helen Koike 2020-01-08 274 {
d65dd85281fbf7f Helen Koike 2020-01-08 275 u32 isp_ctrl = 0, irq_mask = 0, acq_mult = 0, signal = 0;
d65dd85281fbf7f Helen Koike 2020-01-08 276 const struct rkisp1_isp_mbus_info *src_fmt, *sink_fmt;
d65dd85281fbf7f Helen Koike 2020-01-08 277 struct rkisp1_sensor_async *sensor;
d65dd85281fbf7f Helen Koike 2020-01-08 278 struct v4l2_mbus_framefmt *sink_frm;
d65dd85281fbf7f Helen Koike 2020-01-08 279 struct v4l2_rect *sink_crop;
d65dd85281fbf7f Helen Koike 2020-01-08 280
d65dd85281fbf7f Helen Koike 2020-01-08 281 sensor = rkisp1->active_sensor;
d65dd85281fbf7f Helen Koike 2020-01-08 282 sink_fmt = rkisp1->isp.sink_fmt;
d65dd85281fbf7f Helen Koike 2020-01-08 283 src_fmt = rkisp1->isp.src_fmt;
d65dd85281fbf7f Helen Koike 2020-01-08 284 sink_frm = rkisp1_isp_get_pad_fmt(&rkisp1->isp, NULL,
d65dd85281fbf7f Helen Koike 2020-01-08 285 RKISP1_ISP_PAD_SINK_VIDEO,
d65dd85281fbf7f Helen Koike 2020-01-08 286 V4L2_SUBDEV_FORMAT_ACTIVE);
d65dd85281fbf7f Helen Koike 2020-01-08 287 sink_crop = rkisp1_isp_get_pad_crop(&rkisp1->isp, NULL,
d65dd85281fbf7f Helen Koike 2020-01-08 288 RKISP1_ISP_PAD_SINK_VIDEO,
d65dd85281fbf7f Helen Koike 2020-01-08 289 V4L2_SUBDEV_FORMAT_ACTIVE);
d65dd85281fbf7f Helen Koike 2020-01-08 290
003492984ed7fc1 Dafna Hirschfeld 2020-04-06 291 if (sink_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
d65dd85281fbf7f Helen Koike 2020-01-08 292 acq_mult = 1;
003492984ed7fc1 Dafna Hirschfeld 2020-04-06 293 if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
d65dd85281fbf7f Helen Koike 2020-01-08 @294 if (sensor->mbus.type == V4L2_MBUS_BT656)
d65dd85281fbf7f Helen Koike 2020-01-08 295 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_RAW_PICT_ITU656;
d65dd85281fbf7f Helen Koike 2020-01-08 296 else
d65dd85281fbf7f Helen Koike 2020-01-08 297 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_RAW_PICT;
d65dd85281fbf7f Helen Koike 2020-01-08 298 } else {
d65dd85281fbf7f Helen Koike 2020-01-08 299 rkisp1_write(rkisp1, RKISP1_CIF_ISP_DEMOSAIC_TH(0xc),
d65dd85281fbf7f Helen Koike 2020-01-08 300 RKISP1_CIF_ISP_DEMOSAIC);
d65dd85281fbf7f Helen Koike 2020-01-08 301
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 302 if (sensor->mbus_type == V4L2_MBUS_BT656)
d65dd85281fbf7f Helen Koike 2020-01-08 303 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_BAYER_ITU656;
d65dd85281fbf7f Helen Koike 2020-01-08 304 else
d65dd85281fbf7f Helen Koike 2020-01-08 305 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_BAYER_ITU601;
d65dd85281fbf7f Helen Koike 2020-01-08 306 }
003492984ed7fc1 Dafna Hirschfeld 2020-04-06 307 } else if (sink_fmt->pixel_enc == V4L2_PIXEL_ENC_YUV) {
d65dd85281fbf7f Helen Koike 2020-01-08 308 acq_mult = 2;
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 309 if (sensor->mbus_type == V4L2_MBUS_CSI2_DPHY) {
d65dd85281fbf7f Helen Koike 2020-01-08 310 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU601;
d65dd85281fbf7f Helen Koike 2020-01-08 311 } else {
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 312 if (sensor->mbus_type == V4L2_MBUS_BT656)
d65dd85281fbf7f Helen Koike 2020-01-08 313 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU656;
d65dd85281fbf7f Helen Koike 2020-01-08 314 else
d65dd85281fbf7f Helen Koike 2020-01-08 315 isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU601;
d65dd85281fbf7f Helen Koike 2020-01-08 316 }
d65dd85281fbf7f Helen Koike 2020-01-08 317
d65dd85281fbf7f Helen Koike 2020-01-08 318 irq_mask |= RKISP1_CIF_ISP_DATA_LOSS;
d65dd85281fbf7f Helen Koike 2020-01-08 319 }
d65dd85281fbf7f Helen Koike 2020-01-08 320
d65dd85281fbf7f Helen Koike 2020-01-08 321 /* Set up input acquisition properties */
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 322 if (sensor->mbus_type == V4L2_MBUS_BT656 ||
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 323 sensor->mbus_type == V4L2_MBUS_PARALLEL) {
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 324 if (sensor->mbus_flags & V4L2_MBUS_PCLK_SAMPLE_RISING)
d65dd85281fbf7f Helen Koike 2020-01-08 325 signal = RKISP1_CIF_ISP_ACQ_PROP_POS_EDGE;
d65dd85281fbf7f Helen Koike 2020-01-08 326 }
d65dd85281fbf7f Helen Koike 2020-01-08 327
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 328 if (sensor->mbus_type == V4L2_MBUS_PARALLEL) {
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 329 if (sensor->mbus_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
d65dd85281fbf7f Helen Koike 2020-01-08 330 signal |= RKISP1_CIF_ISP_ACQ_PROP_VSYNC_LOW;
d65dd85281fbf7f Helen Koike 2020-01-08 331
4d0b43804c1245c Dafna Hirschfeld 2020-03-17 332 if (sensor->mbus_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
d65dd85281fbf7f Helen Koike 2020-01-08 333 signal |= RKISP1_CIF_ISP_ACQ_PROP_HSYNC_LOW;
d65dd85281fbf7f Helen Koike 2020-01-08 334 }
d65dd85281fbf7f Helen Koike 2020-01-08 335
d65dd85281fbf7f Helen Koike 2020-01-08 336 rkisp1_write(rkisp1, isp_ctrl, RKISP1_CIF_ISP_CTRL);
d65dd85281fbf7f Helen Koike 2020-01-08 337 rkisp1_write(rkisp1, signal | sink_fmt->yuv_seq |
d65dd85281fbf7f Helen Koike 2020-01-08 338 RKISP1_CIF_ISP_ACQ_PROP_BAYER_PAT(sink_fmt->bayer_pat) |
d65dd85281fbf7f Helen Koike 2020-01-08 339 RKISP1_CIF_ISP_ACQ_PROP_FIELD_SEL_ALL,
d65dd85281fbf7f Helen Koike 2020-01-08 340 RKISP1_CIF_ISP_ACQ_PROP);
d65dd85281fbf7f Helen Koike 2020-01-08 341 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_ACQ_NR_FRAMES);
d65dd85281fbf7f Helen Koike 2020-01-08 342
d65dd85281fbf7f Helen Koike 2020-01-08 343 /* Acquisition Size */
d65dd85281fbf7f Helen Koike 2020-01-08 344 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_ACQ_H_OFFS);
d65dd85281fbf7f Helen Koike 2020-01-08 345 rkisp1_write(rkisp1, 0, RKISP1_CIF_ISP_ACQ_V_OFFS);
d65dd85281fbf7f Helen Koike 2020-01-08 346 rkisp1_write(rkisp1,
d65dd85281fbf7f Helen Koike 2020-01-08 347 acq_mult * sink_frm->width, RKISP1_CIF_ISP_ACQ_H_SIZE);
d65dd85281fbf7f Helen Koike 2020-01-08 348 rkisp1_write(rkisp1, sink_frm->height, RKISP1_CIF_ISP_ACQ_V_SIZE);
d65dd85281fbf7f Helen Koike 2020-01-08 349
d65dd85281fbf7f Helen Koike 2020-01-08 350 /* ISP Out Area */
d65dd85281fbf7f Helen Koike 2020-01-08 351 rkisp1_write(rkisp1, sink_crop->left, RKISP1_CIF_ISP_OUT_H_OFFS);
d65dd85281fbf7f Helen Koike 2020-01-08 352 rkisp1_write(rkisp1, sink_crop->top, RKISP1_CIF_ISP_OUT_V_OFFS);
d65dd85281fbf7f Helen Koike 2020-01-08 353 rkisp1_write(rkisp1, sink_crop->width, RKISP1_CIF_ISP_OUT_H_SIZE);
d65dd85281fbf7f Helen Koike 2020-01-08 354 rkisp1_write(rkisp1, sink_crop->height, RKISP1_CIF_ISP_OUT_V_SIZE);
d65dd85281fbf7f Helen Koike 2020-01-08 355
d65dd85281fbf7f Helen Koike 2020-01-08 356 irq_mask |= RKISP1_CIF_ISP_FRAME | RKISP1_CIF_ISP_V_START |
d65dd85281fbf7f Helen Koike 2020-01-08 357 RKISP1_CIF_ISP_PIC_SIZE_ERROR | RKISP1_CIF_ISP_FRAME_IN;
d65dd85281fbf7f Helen Koike 2020-01-08 358 rkisp1_write(rkisp1, irq_mask, RKISP1_CIF_ISP_IMSC);
d65dd85281fbf7f Helen Koike 2020-01-08 359
003492984ed7fc1 Dafna Hirschfeld 2020-04-06 360 if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
bae1155cf5798cc Jacob Chen 2020-01-08 361 rkisp1_params_disable(&rkisp1->params);
bae1155cf5798cc Jacob Chen 2020-01-08 362 } else {
bae1155cf5798cc Jacob Chen 2020-01-08 363 struct v4l2_mbus_framefmt *src_frm;
bae1155cf5798cc Jacob Chen 2020-01-08 364
bae1155cf5798cc Jacob Chen 2020-01-08 365 src_frm = rkisp1_isp_get_pad_fmt(&rkisp1->isp, NULL,
bae1155cf5798cc Jacob Chen 2020-01-08 366 RKISP1_ISP_PAD_SINK_VIDEO,
bae1155cf5798cc Jacob Chen 2020-01-08 367 V4L2_SUBDEV_FORMAT_ACTIVE);
bae1155cf5798cc Jacob Chen 2020-01-08 368 rkisp1_params_configure(&rkisp1->params, sink_fmt->bayer_pat,
bae1155cf5798cc Jacob Chen 2020-01-08 369 src_frm->quantization);
bae1155cf5798cc Jacob Chen 2020-01-08 370 }
bae1155cf5798cc Jacob Chen 2020-01-08 371
d65dd85281fbf7f Helen Koike 2020-01-08 372 return 0;
d65dd85281fbf7f Helen Koike 2020-01-08 373 }
d65dd85281fbf7f Helen Koike 2020-01-08 374
:::::: The code at line 294 was first introduced by commit
:::::: d65dd85281fbf7fc66a936b0aa8979614a7ba150 media: staging: rkisp1: add Rockchip ISP1 base driver
:::::: TO: Helen Koike <helen.koike@xxxxxxxxxxxxx>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
