On 4/21/20 9:12 PM, Sowjanya Komatineni wrote:
On 4/21/20 1:50 PM, Thierry Reding wrote:
On Tue, Apr 21, 2020 at 01:09:50PM +0200, Hans Verkuil wrote:
Hi Sowjanya,
On 21/04/2020 02:11, Sowjanya Komatineni wrote:
This series adds Tegra210 VI and CSI driver for built-in test pattern
generator (TPG) capture.
Tegra210 supports max 6 channels on VI and 6 ports on CSI where each
CSI port is one-to-one mapped to VI channel for video capture.
This series has TPG support only where it creates hard media links
between CSI subdevice and VI video device without device graphs.
v4l2-compliance results are available below the patch diff.
I'm ready to merge this v8. Looking at the series I should only merge
patches 6 and 7, all other patches go through different subsystems,
right?
You could also pick up patch 5 because it adds the bindings that are
implemented by the driver in patch 6. But I can also pick that up into
the Tegra tree. In fact, I do have a set of patches to convert some
Tegra bindings to the new json-schema format and the host1x file is
among them. If I do get around to finish those up for v5.8 it might be
better for me to pick up patch 5 so that I can base my conversion patch
on top of that.
Either way is fine with me, so I've acked the three patches. Take which
ones you want and I'll pick up the rest.
Thanks again for your guidance on this patch set!
Thierry
Hi Hans,
Would like to add a small fix to the driver for explicit check for vi
and csi availability before TPG setup and cleanup in case if video
driver is enabled without device tree support where vi and csi drivers
does not register.
Although we are not enabling driver by default now, would be good to
have this in this series itself.
Will send out the updated version, please pick v9.
Thanks
Sowjanya
Sorry Hans. Just sent v9 which has small fix of explicit check on csi
and vi both channels availability before TPG setup and cleanup.
As for later Tegras (Tegra186+), CSI is not a child device to VI and in
case if either of CSI/VI platform driver register doesn't happen this
explicit check helps to skip TPG setup. Mostly as device tree changes go
with driver updates, should not be real issue but in case of wrong
compatible or missing in device tree to avoid crash added this explicit
check.
Please consider this v9 for merge.
Thanks
Sowjanya
